FANDOM


  • Hi,

    Trying to get a hold of you through wikia chat but to no avail. so I decided to venture out into this my own self. :p

    Is it ok if I convert the rest of those quests (Bw1, Bm1, D1, F1, G1, WA01, etc) into the new template that you have used for the previous quests template that you were using?

      Loading editor
    • It is 100% okay for you to do that. I've had no time to really do the rest of it.

      And hey I'm rarely ever on as it is :V

        Loading editor
    • O.o fast response. :v

      Mind checking a bit to see if the little scratchbox I use is ok to be placed onto the Quests page? thanks.

      Update: Never mind, gonna roll that in now instead.

        Loading editor
    • Hey, I made a template without colors, Template:Quest2, colors are here now (need to add the rest and make a workaround for waifu quests).

        Loading editor
    • Hi がか,

      Not exactly sure how is this much different from the template that is already in use except that yours is in LUA format.

      Also, you should have probably named the template as something like Template:Quest/Draft or something. Just saying. xD

        Loading editor
    • It's

      {{Quest
      |ID = A1
      |Title_JP = はじめての「編成」!
      |Title_EN = The First Organization
      |Requirements = Have 2 ships in your main fleet
      |Rewards_RSC = 20 / 20 / 0 / 0
      |Rewards_Items = {{ShipLink|Shirayuki}}
      |Note = 
      }}
      

      instead of

      {{Quest
      |ID = A1
      |Title_JP = はじめての「編成」!
      |Title_EN = The First Organization
      |Requirements = Have 2 ships in your main fleet
      |Rewards_RSC = 20 / 20 / 0 / 0
      |Rewards_Items = {{ShipLink|Shirayuki}}
      |Note = 
      |ID_Color = #43C769
      |Title_Color = #D7F3C7
      |Separator_Color = #DBE6D5
      |Odd_Color = #F2F7F0
      }}
      

      i.e. no color arguments required (colors are recovered from ID).

      It should replace Quest template anyway (with deletion of Quest2), just want to know if there is any concerns about switching to Lua (new colors should be added in that Lua table, though I can also add support for optional *_Color arguments).

        Loading editor
    • Oh I see, no color arguments. I did notice that you only have one variation of it available on your Template:Quest2. Was thinking maybe if it could possible to expand more on the colors for all the various quests.

        Loading editor
    • Ok, now it works for all quests (only Marriage Quests use color parameters).

        Loading editor
    • Nice! I just added a minor adjustment to that Template page of yours. I think it is now ready to be pushed out onto the real page and maybe update Template:Quest

        Loading editor
    • Geez, I see you guys went to work while I was asleep :V

      Having LUA handle the color arguments will help with adding new quests, so I have no problem with that. You have my approval to push it on to the main page, if everything is squared away.

        Loading editor
    • This is what happens when you delegate the work off to others. You almost made it sound like as if you don't care about that Quests page no more. Pacman

      I am all in for trimming down the "overall weight" of the page and well easier on the eyes for others to come along and edit as well. Though initially I did see what がか was doing and I had no clue but now it made sense and well, trimming bits and pieces off helps.

        Loading editor
    • Template:Quest2 <- now can be deleted

        Loading editor
    • Thanks a bunch for the hard work がか! too bad I am no admin and so I can't delete that template/page. The least I can do is probably mark it for deletion.

        Loading editor
    • I was just joking, CT.

      I'll delete the page.

        Loading editor
    • There are those timeout script errors on the page now, with over 500 transclusions (it was under 500 before new quests) that involve Lua Wikia just decide to stop rendering the page at a certain point from time to time (I tried purge, but errors still come back eventually, even without any edits), both Quest and ShipBattleCardKai start giving timeouts.

      I've fixed it for now so there is no "Script error" displayed, but they are still here internally, so some ship tooltips will be replaced with simple links and some rows will be colored in gray (since Quest Lua can't chose colors).

      What I suggest is to go back to simple Quest template (no Lua), but use the following CSS (CSS3) for coloring

      [class^="quest_id_A"] { background: #43C769; }
      [class^="quest_title_A"] { background: #D7F3C7; }
      [class^="quest_separator_A"] { background: #DBE6D5; }
      [class^="quest_row_A"]:nth-child(4n+3) { background: #F2F7F0; }
      [class^="quest_row_A"]:nth-child(4n+5) { background: #FFFFFF; }
      
      [class^="quest_id_B"] { background: #EC6063; }
      [class^="quest_title_B"] { background: #F3DCDC; }
      [class^="quest_separator_B"] { background: #EDE2E2; }
      [class^="quest_row_B"]:nth-child(4n+3) { background: #FCF8F8; }
      [class^="quest_row_B"]:nth-child(4n+5) { background: #FFFFFF; }
      
      [class^="quest_id_C"] { background: #93CE67; }
      [class^="quest_title_C"] { background: #E5F3DB; }
      [class^="quest_separator_C"] { background: #E6EDE0; }
      [class^="quest_row_C"]:nth-child(4n+3) { background: #F8FAF5; }
      [class^="quest_row_C"]:nth-child(4n+5) { background: #FFFFFF; }
      
      [class^="quest_id_D"] { background: #4EBBD4; }
      [class^="quest_title_D"] { background: #DFF0F9; }
      [class^="quest_separator_D"] { background: #E8EDF0; }
      [class^="quest_row_D"]:nth-child(4n+3) { background: #F1F7FA; }
      [class^="quest_row_D"]:nth-child(4n+5) { background: #FFFFFF; }
      
      [class^="quest_id_E"] { background: #DEC772; }
      [class^="quest_title_E"] { background: #F0E4B5; }
      [class^="quest_separator_E"] { background: #DDD9C8; }
      [class^="quest_row_E"]:nth-child(4n+3) { background: #F5F2E4; }
      [class^="quest_row_E"]:nth-child(4n+5) { background: #FFFFFF; }
      
      [class^="quest_id_F"] { background: #BA8F79; }
      [class^="quest_title_F"] { background: #D9B38C; }
      [class^="quest_separator_F"] { background: #C6B39F; }
      [class^="quest_row_F"]:nth-child(4n+3) { background: #F3ECE6; }
      [class^="quest_row_F"]:nth-child(4n+5) { background: #FFFFFF; }
      
      [class^="quest_id_G"] { background: #CAA6DD; }
      [class^="quest_title_G"] { background: #EFE8F7; }
      [class^="quest_separator_G"] { background: #EFEBF3; }
      [class^="quest_row_G"]:nth-child(4n+3) { background: #FAF8FC; }
      [class^="quest_row_G"]:nth-child(4n+5) { background: #FFFFFF; }
      
      [class^="quest_id_W"] { background: #FDD0F0; }
      [class^="quest_title_W"] { background: #EFE8F7; }
      [class^="quest_separator_W"] { background: #F5F3F8; }
      [class^="quest_row_W"]:nth-child(4n+3) { background: #FFF7FF; }
      [class^="quest_row_W"]:nth-child(4n+5) { background: #FFFFFF; }
      
        Loading editor
    • Just a thought that we could also instead of having all the quests in one page, we employ the use of tabview which basically takes advantage of multiple pages to be included as one page (similar to how Expedition page works but not identical). That way we might still get around the issue of 500 quest entries which breaks the rendering but also make it less scrolling.

      I think that probably has less of a overhead to work at and maintain compared to having all in one page.

        Loading editor
    • Maybe, if you have an idea how to do it right :) (like cross-page links, do you load new page every time?, comments spread between pages, tabbing on the main page...)

      I just thought that coloring in Lua is actually a bad idea when you can do it client-side (those CSS3 features seem to be supported widely on desktop/mobile).

        Loading editor
    • Unfortunately no. I was actually looking at ways to kill two birds with one stone.

        Loading editor
    • Also, there are many Quests#ID links outside the quests page.

        Loading editor
    • I've been thinking about how to best handle all the issues we've been getting lately, but I've come up with nothing. 

      The disadvantages of only understanding CSS and HTML on a basic level. : / 

        Loading editor
    • I have trouble with script errors on Ship list and Remodel. I think it happens when wikia decides to refresh the cached page during peak times and because of the higher than normal load on the servers the amount of Lua that can be run before timeout happens is less.

      It's possible to use mw.loadData to load data modules which should mean that multiple #invoke's on the same page will only load unique data modules once, but it will mean additional overhead when accessing the data itself, since I can no longer use the data table itself as the base for the ShipData wrapper; the ShipData wrapper will have to have a reference to the data table and every data access will go through one more lookup. This means that pages will be a (tiny?) bit slower across the board in exchange for pages that access data modules more than once across multiple invokes (ship pages, pages with lots of ShipCardKai etc template level calls) should get a noticeable speed increase.

      Of course, this is assuming my understanding that requires are slow compared to lookups is correct. It's a big change at the core of the Lua system though, so I've been hesitant to try it. If I break something literally everything Lua will break =/

      Tbh, I really want to try to ask Wikia admin to increase Lua timeouts for our wikia instead =/

        Loading editor
    • SmokeyTheButt wrote:

      I've been thinking about how to best handle all the issues we've been getting lately, but I've come up with nothing. 

      The disadvantages of only understanding CSS and HTML on a basic level. : / 

      Fortunately (?) you're not the only one there. I too have very limited knowledge of how things work. I am more or less a sitting duck when it comes to LUA stuff and/or advanced programming.

        Loading editor
    • I'm glad we have a common ground then _(:3J L)_

        Loading editor
    • How about Sandbox/Test ?

        Loading editor
    • A FANDOM user
        Loading editor
Give Kudos to this message
You've given this message Kudos!
See who gave Kudos to this message
Community content is available under CC-BY-SA unless otherwise noted.