Thread:がか/@comment-460323-20170530184328/@comment-460323-20170629211948

Finally done with converting all Shipquote to ShipQuote. Just noticed that even 改 in the JP text is removed when using the script, so I'll go through the ship pages again later to add them back in.

And here's a list of stuff that needs fixing:

Non-audio stuff:

 Z1 & Z3 have Type 1934 as their class name instead of Type 1934 Class. I've no idea which part of the module causes this exception, but due to this inconsistency, there are now 2 Type 1934 templates, one with Class and one without. Requesting change from Type 1934 -> Type 1934 Class and deleting the Template:Type_1934 page. In Yamakaze and Commandant Teste's module, there's a get_message field that I removed. Not sure if it's gonna break stuff :v. Ships with multiple ship type (e.g. Taigei/Ryuuhou) need to have more than 1 List of [Ship class] in ShipPageFooter (e.g. List of Submarine Tenders / List of Light Aircraft Carrier). Ships with multiple ship class (e.g. U-511/ Ro-500) need multiple ship-class template in ShipPageFooter (e.g. Type IXC / Ro-series) Using ShipPageHeader removed the Vita Basic and Upgrade info of Iowa. Don't think it's required tho. 

Missing audio / Requires renaming:

 The entire audio for Chitose & Chiyoda (currently audio using Kai2 suffix instead of Carrier and CarrierKai2) I-13 / I-14 / I-26 are (probably) missing their Air Battle audio</li> Ooi Base Attack missing</li> Ooi Construction Kai Ni missing</li> Zuihou Starting a Sortie Kai missing.</li> Kaga Minor Damage 2 missing.</li> </ol>

Ship hourly naming errors:

 Fubuki hourly is FubukiKai2-00 instead of Fubuki-00 as with other ships' hourlies. Currently, I'm using Ship = FubukiKai2 to circumvent this.</li> Mogami hourly is MogamiKai instead of Mogami</li> Yamato hourly is Yamato Kai instead of Yamato</li> Musashi hourly is Musashi Kai instead of Musashi</li> Littorio's hourly is Italia instead of Littorio</li> Taigei's hourly is Ryuuhou instead of Taigei</li> Prinz Eugen hourly is currently using the old 30 system instead of the new 00 system</li> Shoukaku hourly is currently using the old 30 system instead of the new 00 system</li> Zuikaku hourly is currently using the old 30 system instead of the new 00 system</li> </ol>

Possible duplicates in Base and remodeled lines, might want to delete the Kai audio:

 Mogami Supply & Supply Kai</li> <li>Yamato possible dups? Library, Idle, Wedding, Equipment 3, Supply, Starting a Sortie, MVP, Minor Damage 1, Minor Damage 2, Major Damage, Sunk.</li> <li>Musashi possible dups? Library, Idle, Wedding, Equipment 3, Supply, MVP, Minor Damage 1, Minor Damage 2, Major Damage, Sunk.</li> <li>Taihou possible dups? Idle, Wedding, Equipment 3, Supply, Minor Damage 1, Minor Damage 2, Major Damage</li> <li>Amagi possible dups? Secretary 2, Looking At Scores, Equipment 1, Equipment 2, Equipment 3, Supply, Docking Minor, Docking Major, Construction, Returning From Sortie, Starting A Sortie, Air Battle, Attack, Night Battle, Minor Damage 1, Minor Damage 2, Major Damage, Sunk</li> <li>I-401 possible dups? Library, Secretary 1 (Kai same as Secretary 2 Kai), Idle, Wedding, Equipment 2 (Kai same as Equipment 3 Kai), Supply, MVP, Minor Damage 1, Minor Damage 2, Major Damage, Sunk</li> <li>Maruyu possible dups? Library, Idle, Wedding, Equipment 3, Supply, MVP, Minor Damage 1, Minor Damage 2, Major Damage, Sunk</li> </ol>

Possible error that requires confirmation (I've no idea what's the current way to compare and check for legit audio nowadays):

<ol> <li>Akatsuki Secretary2 - Kai(Original) to K2(Based on audio file).</li> <li>In the old shipquote, Asagumo had two attack line, but there's only one audio file. Requesting confirmation.</li> <li>Yukikaze has no idle lines</li> <li>Hamakaze may or may not have a Kai "Start a sortie"/"Battle start" line. 第十七駆逐隊、浜風、出撃します！ was in the original but there's no audio for it. It is the same line as Joining a fleet (Kai) so this might be a mistake in the original.</li> <li>Amagi Looking at scores & returning from fleet kai are swapped</li> </ol>